angular-ui / ui-leaflet

AngularJS directive to embed an interact with maps managed by Leaflet library
http://angular-ui.github.io/ui-leaflet
Other
315 stars 137 forks source link

Request for custom control: L.HistoryControl #137

Open nmccready opened 8 years ago

nmccready commented 8 years ago

From @milovanderlinden on October 26, 2015 15:9

I would like to have the directive extended to support L.HistoryControl. I will first try to implement this myself and send a pull request when finished.

https://github.com/cscott530/leaflet-history

Copied from original issue: tombatossals/angular-leaflet-directive#1004

nmccready commented 8 years ago

Sounds good as long as it is pluggable.

nmccready commented 8 years ago

Please include specs as well.

nmccready commented 8 years ago

From @milovanderlinden on October 26, 2015 19:31

I discovered that L.HistoryControl had some dependencies on jQuery, so I rewrote it to fit angular. Pullrequest is pending: https://github.com/cscott530/leaflet-history/pull/5/files

nmccready commented 8 years ago

Nice way to use the leaflet utils.

nmccready commented 8 years ago

From @milovanderlinden on October 26, 2015 22:40

Yes, the less external dependencies, the better.

nmccready commented 8 years ago

From @milovanderlinden on October 28, 2015 20:3

Step one taken; my issue has been merged! https://github.com/cscott530/leaflet-history/pull/5#event-448454741

nmccready commented 8 years ago

:+1: