search

angular-ui / ui-leaflet

AngularJS directive to embed an interact with maps managed by Leaflet library
http://angular-ui.github.io/ui-leaflet
Other
314 stars 134 forks source link

Error on paths events #154

Open nmccready opened 9 years ago

nmccready commented 9 years ago

From @antoinegiret on April 16, 2015 15:9

Hi, I have an error when a path event is fired on my map, like a mouseeenter :

ReferenceError: fire is not defined

Any idea with this issue ? Thanks.

Copied from original issue: tombatossals/angular-leaflet-directive#689

nmccready commented 9 years ago

From @antoinegiret on April 17, 2015 12:41

I have the code of angular-leaflet-directive 0.7.13 2015-04-14 I modified the following function :

angular.module("leaflet-directive").factory('leafletPathEvents', [..., "leafletEventsHelpers", function (..., leafletEventsHelpers) {    var fire = leafletEventsHelpers.fire;

    ...

}]);

nmccready commented 9 years ago

From @iamsortiz on April 19, 2015 20:24

Same error with bower install done today.

Code on github already has the fix: https://github.com/tombatossals/angular-leaflet-directive/blob/master/dist/angular-leaflet-directive.js#L4433

Using that fixed .js from github solved the issue.

I don't know much about bower, but maybe bower it's using an older unfixed code on install.

nmccready commented 9 years ago

Yes a new release needs to be cut.