angular-ui / ui-leaflet

AngularJS directive to embed an interact with maps managed by Leaflet library
http://angular-ui.github.io/ui-leaflet
Other
315 stars 137 forks source link

ui-leaflet website basic Getting Started instructions not complete #252

Open redfox05 opened 8 years ago

redfox05 commented 8 years ago

I know this is not really a "bug" as such, but I can't update the main ui-leaflet website, so posting here will have to do, then others know its raised as well.

Issue 1

On the getting started page, the link to the examples page points to "http://angular-ui.github.io/ui-leaflet/#!/getting-started" instead of "http://angular-ui.github.io/ui-leaflet/#!/examples/"

Issue 2

On both the getting started page and the examples page, there is no mention of adding the dependancy into the app. You need to state that we need to add "ui-leaflet" to the Angular module dependancies. I know it sounds obvious, but for a newbie to angular/ui-leaflet, this is not clear. Especially when the Getting Started page says "Thats All":

"And that's all. Now you can start embedding maps to your application adding the custom tag with some attributes on your HTML code, and interacting with the scope of your controller. "

Issue 3

The Simple Example page actually mentions adding the dependancy, but states

"We only have to add leaflet-directive to our AngularJS application dependencies"

but this is incorrect as it should say:

"We only have to add ui-leaflet to our AngularJS application dependencies"

Please can you correct the above issues on the website, so that others new to ui-leaflet and maybe angular in general can understand and use it without simple problems like these?

Kind regards, Russell

elesdoar commented 8 years ago

Hi @redfox05 ,

Thanks for reporting, We'll working soon on this, though, please feel free to fork repo and send us a pull request.