Destroying scope should only remove its own defaults

angular-ui / ui-leaflet

AngularJS directive to embed an interact with maps managed by Leaflet library

http://angular-ui.github.io/ui-leaflet

Other

314 stars 134 forks source link

Destroying scope should only remove its own defaults #346

Open eugenehuangsg opened 7 years ago

eugenehuangsg commented 7 years ago

Dynamically instantiated maps's defaults are removed when other maps are removed. eg. using ng-if to toggle displaying of different tabs.

eugenehuangsg commented 7 years ago

Similar implementation to https://github.com/angular-ui/ui-leaflet/pull/322

npm test runs well locally. Build error is probably due to one of the package.json dependencies. I'm still unable to isolate which dependencies is causing the problem. https://github.com/angular-ui/ui-leaflet/issues/347

elesdoar commented 7 years ago

Please check this commit, https://github.com/angular-ui/ui-leaflet/commit/fee0175b68d9a754a46196d81173e360c5a97fbf,

all efforts will be focused on the version for Leaflet 1.x

Thanks.