angular-ui / ui-leaflet

AngularJS directive to embed an interact with maps managed by Leaflet library
http://angular-ui.github.io/ui-leaflet
Other
315 stars 137 forks source link

Confusion around tileLayerOptions and layerOptions #48

Open nmccready opened 8 years ago

nmccready commented 8 years ago

From @facultymatt on February 6, 2015 18:56

The use cases for tileLayerOptions and layerOptions are unclear in the examples and documentation.

For example here:

https://github.com/tombatossals/angular-leaflet-directive/blob/9cc9fd1426161b496dfc1e385c3255077c966986/examples/custom-parameters-example.html#L20-L24

and here:

https://github.com/tombatossals/angular-leaflet-directive/blob/dab1c1e1b7d0ea3c8fab6d5d94096e5ed4d6aaed/test/unit/leafletDirectiveSpec.js#L100-L103

However in practice I have found that to get detectRetina to work, you need to put it inside layerOptions and not tileLayerOptions as suggested.

The two above links should be corrected, or the documentation clarified to remove confusion here.

Copied from original issue: tombatossals/angular-leaflet-directive#625

nmccready commented 8 years ago

From @seadour on August 26, 2015 18:2

+1 on this. Documentation and examples are unclear on when to use layerOptions and when to use tileLayerOptions.

I, too, can only get detectRetina to work under layerOptions, but I can't figure out what exactly makes my map project different from the examples.