search

angular-ui / ui-map

Google Maps
http://angular-ui.github.io/ui-map
MIT License
288 stars 93 forks source link

Fix multiple compilations from duplicating items in ng-repeat #13

Open runxc1 opened 11 years ago

runxc1 commented 11 years ago

https://github.com/angular-ui/ui-map/issues/12

ProLoser commented 11 years ago

Think you could add a unit test or 2 to show this fixes the bug in question?

Valorum commented 11 years ago

Do we need the compile flag & check at all? It seems that simply commenting out lines 73-78 in the original works as expected.

EDIT:

Found that it needs to compile once or else ng-click won't work. Don't need to decorate the infoWindow.open() though; compiling once in the link function seems to suffice. See https://github.com/Valorum/ui-map/commit/327d7ef2fb95e25ebc2b47596319a601cddfd20d

brooly commented 11 years ago

Can this pull request being merged or the Valorum's one... The issue is still happening

conorw commented 10 years ago

This fix works for me, it has stopped the event handlers from multiplying.

sandcastle commented 10 years ago

+1

rsantosdev commented 10 years ago

@Valorum fix worked fine for me, please accept that

sandcastle commented 10 years ago

Any update on if this will be accepted? - its been open for over a year now.