search

angular-ui / ui-position

Helper class used by a lot of angular projects on the web
MIT License
1 stars 5 forks source link

Move ui-bootstrap/position here #1

Open ProLoser opened 9 years ago

ProLoser commented 9 years ago

So in line with the splitting up of ui-utils, a LOT of projects use nearly identical code to angular-ui/ui-bootstrap's position service. I believe it would be extremely useful to a LOT of projects online if we separated it out and let people use it as a dependency. This way we could collectively improve and streamline the logic used for all angular suites.

@PowerKiKi you have been doing such an awesome job helping split up ui-utils, I was hoping you wouldn't mind doing the same thing with the $position service?

This would not entail making any changes to ui-bootstrap at the moment, but would at least lay out the groundwork for them to eventually switch to relying on this repository as a dependency.

Also pinging @wesleycho

PowerKiKi commented 9 years ago

I could to that if ui-boostrap people agree with the idea. @pkozlowski-opensource, @bekos, @chrisirhc what do you think about that ?

chrisirhc commented 9 years ago

Sounds good to me, we've had a brief discussion about this before over Slack. There are a bunch of issues about $position at the moment and @wesleycho would be more familiar with them as he has been reviewing them more recently. I think moving them out here is a start.

My only concern right now is that there are some big changes coming to it but no PR actually has been working on getting those changes into $position, they're instead adding that position logic into datepicker, toolpicker etc. We need to redirect those efforts to ui-position / $position, which we should be doing anyway.

PowerKiKi commented 9 years ago

It sounds it would be best if someone more familiar with $position would do the actual split. I feel like I might not be the best person for that, even though I would gladly help.

@chrisirhc would you be willing to do the split whenever/however would best suit ui-bootstrap development ?

wesleycho commented 9 years ago

Copying/pasting the script & test from master is the simplest way - it is just a service.

I am not sure what the test.html file is used for in the test directory.

The more complicated part is setting up the build tooling.

PowerKiKi commented 9 years ago

If needed I can setup the build tools (as long as gulp is fine with you). But first of all we should be sure how to handle existing PR/issues so it won't be too much trouble later on...

RobJacobs commented 9 years ago

I think this is a great idea, I hate seeing the same code repeated as chris mentioned. It would like to see an auto position feature implemented where the service would return a position based on available space. AngularStrap implemented something along those lines and I created a similar implementation based of the angular-ui-bootstrap $postion service, demo plunk.

ProLoser commented 9 years ago

Keep in mind that setting up this project and then removing it from bootstrap can and should be two separate steps. They do not have to occur at the same time.

On Tue, Jul 7, 2015, 4:47 AM Rob Jacobs notifications@github.com wrote:

I think this is a great idea, I hate seeing the same code repeated as chris mentioned. It would like to see an auto position feature implemented where the service would return a position based on available space. AngularStrap implemented something along those lines and I created a similar implementation based of the angular-ui-bootstrap $postion service, demo plunk http://plnkr.co/edit/XWYE6iIvYmDpwlk8K0A3?p=preview.

— Reply to this email directly or view it on GitHub https://github.com/angular-ui/ui-position/issues/1#issuecomment-119179529 .

ProLoser commented 8 years ago

@PowerKiKi @RobJacobs @wesleycho @chrisirhc I totally forgout about it, but I think we should close this repo (yes, before it even got started) and adopt Tether instead. Bootstrap is doing the same and is probably going to be the most reliable resource for such logic moving forward. I would hope an angular wrapper isn't necessary.

pkozlowski-opensource commented 8 years ago

Yeh, but Tether seems to be 20K+ of minified code and most of its logic is probably not relevant for what we need... We should investigate it more before switching to any 3rd party

icfantv commented 8 years ago

It doesn't look like it supports modular builds, but according to this link, we can disable (and then remove?) what we don't intend to support.