search

angular-ui / ui-router

The de-facto solution to flexible routing with nested views in AngularJS
http://ui-router.github.io/
MIT License
13.54k stars 3k forks source link

uirouter/angularjs dependency tied to 5.0.3 #3473

Closed jmlopez-rod closed 4 years ago

jmlopez-rod commented 7 years ago

uirouter/angularjs still has uirouter/core@5.0.3 as a dependency instead of newly released one:

https://github.com/angular-ui/ui-router/blob/0ac932a285a7a99ef195b44c2a50c026c36bb338/package.json

"dependencies": {
    "@uirouter/core": "5.0.3"
  },
  "peerDependencies": {
    "angular": ">=1.2.0"
  },

Can you use the ^ so that npm can download the newest version of angularjs/core? I'm having an issue with the views and I'm hoping the newest release (5.0.4) fixes it. Thanks.

EDIT: Just noticed that yarn.lock is not in the .npmignore file, same goes for rollup.config.js. Some files just don't seem to be necessary for the published version. screen shot 2017-06-15 at 5 09 31 pm

christopherthielen commented 7 years ago

Each released version of uirouter/angularjs is tied to a specific version of uirouter/core.

It is bad for users to installed the same version of uirouter/anguarjs one day, but see different behavior when they install the exact same version at a later date (due to changes in core)

To get fixes from core into uirouter/angularjs we need to release a new version of uirouter/angularjs

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues may be reopened.

Thank you for your contributions.

jmlopez-rod commented 4 years ago

Thank you stale bot, i think this is no longer needed, i'll close it up for you.