search

angular-ui / ui-router

The de-facto solution to flexible routing with nested views in AngularJS
http://ui-router.github.io/
MIT License
13.56k stars 3.01k forks source link

fix(uiSrefActive): don't match fuzzy on lazy loaded future states #3619

Closed fpipita closed 6 years ago

fpipita commented 6 years ago

This PR addresses an issue I've got into by working with lazy loaded future states and the ng-{style,class} interface.

Basically, the directive didn't update its private list of the known states when future states were resolved so the uiSrefActive instances that were linked before the lazy states were added to the stateRegistry, kept incorrectly doing a fuzzy match on all the future state's lazily registred children.

christopherthielen commented 6 years ago

thanks!