search

angular-ui / ui-router

The de-facto solution to flexible routing with nested views in AngularJS
http://ui-router.github.io/
MIT License
13.56k stars 3.01k forks source link

Tests not compiling with 1.0.17 #3694

Closed jgraham0325 closed 6 years ago

jgraham0325 commented 6 years ago

This is a (check one box):

My version of UI-Router is: 1.0.17

Bug Report

Current Behavior:

On local machine:

  1. bower update
  2. gulp test

Getting an error running tests: 08:02:50 [INFO] [08:02:50] Starting 'test'... 08:03:23 [INFO] 14 05 2018 08:03:23.750:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/ 08:03:23 [INFO] 14 05 2018 08:03:23.758:INFO [launcher]: Starting browser PhantomJS 08:03:24 [INFO] 14 05 2018 08:03:24.159:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket P9liDdWm-S-ldcg9AAAA with id 54753505 08:03:24 [INFO] PhantomJS 2.1.1 (Linux 0.0.0) ERROR 08:03:24 [INFO] SyntaxError: Unexpected token ')' 08:03:24 [INFO] at /opt/jenkins/jenkins_slave/workspace/ui.app_00_verify/bower_components/angular-ui-router/release/angular-ui-router.js:989

Expected Behavior:

Tests pass, as they did a few days ago with 1.0.15

davidwickman commented 6 years ago

looks to be a duplicate of https://github.com/angular-ui/ui-router/issues/3696 fixed in https://github.com/angular-ui/ui-router/commit/a1266b97328fe2aeb376fec87094fb8512b401bb#diff-ff25e0d5bd5e29e4c0a514d47835cc16

christopherthielen commented 6 years ago

Should be fixed in 1.0.18 See https://github.com/angular-ui/ui-router/issues/3693