search

angular-ui / ui-router

The de-facto solution to flexible routing with nested views in AngularJS
http://ui-router.github.io/
MIT License
13.56k stars 3.01k forks source link

Syntax error in IE 11 #3696

Closed Wideweb closed 6 years ago

Wideweb commented 6 years ago

This is a (check one box):

My version of UI-Router is: 1.0.17

Bug Report

Current Behavior:

Application fails in IE 11 because of Syntax error in angular-ui-router.js (Line: 989, Column: 11). There was no such error in version 1.0.15.

Expected Behavior:

Application runs successfully in IE 11

Nickman87 commented 6 years ago 
          result.push(
            args.map(function(array) {
              return array[i];
            }),
          );
          break;

IE (and other browsers) do not like the trailing comma in function arguments

christopherthielen commented 6 years ago

As it turns out, this was due to accidentally running prettier on the bundles before publishing to bower. NPM bundles were not affected. See https://github.com/angular-ui/ui-router/issues/3693

christopherthielen commented 6 years ago

Also, I just published a new version and it should work as before.

maximilianschmid commented 6 years ago

tested. now works again. thx.