angular-ui / ui-router

The de-facto solution to flexible routing with nested views in AngularJS
http://ui-router.github.io/
MIT License
13.54k stars 3k forks source link

Update @uirouter/core dependency to 6.0.9 #3847

Closed nsgundy closed 1 year ago

nsgundy commented 1 year ago

This is a:

My version of UI-Router is:

    "@uirouter/angular": "^11.0.0",
    "@uirouter/angular-hybrid": "^14.0.0",
    "@uirouter/angularjs": "^1.0.30",
    "@uirouter/core": "^6.0.9",

Feature Request

Please update @uirouter/angularjs dependency on @uirouter/core to 6.0.9, so that it can be used in an Angular/Angularjs hybrid app with Angular at v15.

Currently @uirouter/angularjs depends on @uirouter/core version 6.0.8. This does cause a type mismatch with the StateDeclaration interface.

wawyed commented 1 year ago

Updated to latest core version also moved to peerDeps so it's easy to change version of core without conflicts.

nsgundy commented 1 year ago

I can confirm the issue is now gone using the following versions:

    "@uirouter/angular": "^11.1.0",
    "@uirouter/angular-hybrid": "^15.0.2",
    "@uirouter/angularjs": "^1.1.0",
    "@uirouter/core": "^6.1.0",
    "@uirouter/rx": "^1.0.0",

Cheers :champagne:

wawyed commented 1 year ago

awesome :D