search

angular-ui / ui-scroll

Unlimited bidirectional scrolling over a limited element buffer for AngularJS applications
http://angular-ui.github.io/ui-scroll/demo/
MIT License
327 stars 107 forks source link

Is the .idea directory intentionally published in npm #235

Closed svilenvelikov closed 5 years ago

svilenvelikov commented 5 years ago

I have installed 1.7.6 and found that the .idea directory is also present in the library under node_modules. Is this intentional? If not I guess it could be removed. I find it a bit error prone to have .gitignore and .npmignore in the same time because it's not immediately obvious what will be effectively published in the registry.

dhilt commented 5 years ago

@svilenvelikov Thanks for the issue! Basically we want to have some folders in the repo and don't want to have them in the result package. For example, tests. The thing is our .npmignore is not perfectly synced with what is going on around, for example Gruntfile.js had been off about 2 years ago.

On the ignoring strategy obviousity... if a project has both an .npmignore and .gitignore file, npm will only use the .npmignore file.

Anyway, I've just pushed some changes related to .npmignore in master, so the next release should be clean.

svilenvelikov commented 5 years ago

Great. Thanks.