search

angular-ui / ui-scrollpoint

Add a 'ui-scrollpoint' class to elements when the page scrolls past them.
https://htmlpreview.github.io/?https://github.com/angular-ui/ui-scrollpoint/master/demo/index.html
MIT License
28 stars 25 forks source link

fix for ui-scrollpoints nested in positioned parents #14

Closed plong0 closed 8 years ago

plong0 commented 8 years ago

ui-scrollpoints were not working correctly when nested under parents with either absolute or relative positions set. this patch fixes this, including positioned parents within ui-scrollpoint-targets

PowerKiKi commented 8 years ago

could you rebase this on master please ?

Also if you can avoid committing dist/ when creating a PR, that would avoid conflicts such as this one.

plong0 commented 8 years ago

rebased...

yes, I will avoid committing /dist in future. sorry for doing that in my PR's so far.

PowerKiKi commented 8 years ago

Released as 2.0.1