angular-ui / ui-slider

jQuery UI Slider for AngularJS
https://htmlpreview.github.io/?https://github.com/angular-ui/ui-slider/master/demo/index.html
MIT License
265 stars 176 forks source link

Update documentation #5

Closed ProLoser closed 8 years ago

aolieman commented 11 years ago

Please consider adding a note in the docs about how the load order of js dependencies matters. I just wasted about 2 hours trying to do it like this: (I was integrating into an existing angular app, and figured the issue must be there)

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular.min.js"></script>
<script src="http://code.jquery.com/jquery-1.9.1.js"></script>
<script src="http://code.jquery.com/ui/1.10.3/jquery-ui.js"></script>

I thought the only thing that would matter was that slider.js should be run after the above dependencies, because there are no dependencies between jQuery and angular. Trial and error have made me a bit wiser now, but why is this commonsense for JavaScript folks?

ProLoser commented 11 years ago

You should add a note to the core library instead of all the plugins