search

angular-ui / ui-slider

jQuery UI Slider for AngularJS
https://htmlpreview.github.io/?https://github.com/angular-ui/ui-slider/master/demo/index.html
MIT License
265 stars 176 forks source link

Surrounding slider destroy event with try/catch. #75

Closed samypr100 closed 9 years ago

samypr100 commented 9 years ago

This will allow ui-slider to be used on with ui-bootstraps modals without throwing. The problem happens when the dom is destroyed before the scope. See my comment in issue #41.

PowerKiKi commented 9 years ago

I would rather avoid the use of try/catch and instead try to better detect the situation and act appropriately. IMHO this should not be merged as is.

PowerKiKi commented 9 years ago

Merged #78 instead