Closed arjunasuresh3 closed 8 years ago
@deeg plunker with the fix.
Thanks for posting this PR with the screenshot plunker and to the correct branch.
I will try and review tonight and we can merge in barring any changes needed.
One thing I want to get people in the habit of is writing tests for their changes, so we can start to get full coverage. If you wouldn't mind updating the PR with some tests that would be great.
In this case since it is an important fix, might fix some other issues, and the state of the tests is not up to par right now, I am okay letting it slide this time. I plan to add/update the tests in the near future to try and get full coverage when I have some more time.
@deeg I will add test cases in my free time. Held up at important tasks.
@arjunasuresh3, sorry I have not had time to look at this. I will get to it ASAP
@arjunasuresh3, I reviewed the difference in heap snapshot and timeline both with & without your pull request.
They seem to be the same to me. Seems like after the garbage collection runs (when the values in the timeline dip) the values go back to very similar numbers.
Would you mind describing to me the difference in the timelines which shows a memory leak that was fixed?
Closing this due to inactivity. I'm happy to have more discussion on #191.
…ion using pub-sub pattern to detach circular references between tinymce object and angularjs objects.
Attaching profile screen shot:![tinymce_fix](https://cloud.githubusercontent.com/assets/1137889/11177907/ece85584-8c6e-11e5-8f74-8c21b61dd2b6.jpg)
Fixes #191