Closed rbecheras closed 8 years ago
Thanks for posting this PR.
I will look over all of the PRs and try to get the merged later tonight.
@rbecheras, thanks for posting this PR.
I took most of your changes, minus the addition of the SetContent event. Please see my comment on the issue (#210) and we can continue the discussion there.
If it ends up we actually do need SetContent you can open another PR sticking that one in there, with an appropriate test.
@deeg ,
As you can see, we can refactor events handler that ends with saving model and updating view.
However, before merging this PR, please consider merging my previous PR, that contain changes on the same block of code. This PR is from a local branch
refactor-event-handlers
on my fork that come from the branchbugfix-#210-model-not-saved-after-inserting-images
that is my previous PR.In one word, this PR is made on top of my previous PR, but in a new topic branch
And my log graph representing my history by branches to illustrate
master -> bugfix-#210-model-not-saved-after-inserting-images -> refactor-event-handlers