search

angular-ui / ui-tinymce

AngularUI wrapper for TinyMCE
MIT License
488 stars 371 forks source link

Refactor event handlers #233

Closed rbecheras closed 8 years ago

rbecheras commented 8 years ago

@deeg ,

As you can see, we can refactor events handler that ends with saving model and updating view.

However, before merging this PR, please consider merging my previous PR, that contain changes on the same block of code. This PR is from a local branch refactor-event-handlers on my fork that come from the branch bugfix-#210-model-not-saved-after-inserting-images that is my previous PR.

In one word, this PR is made on top of my previous PR, but in a new topic branch

see my previous PR: https://github.com/angular-ui/ui-tinymce/pull/232

And my log graph representing my history by branches to illustrate master -> bugfix-#210-model-not-saved-after-inserting-images -> refactor-event-handlers

* 73d05cf (HEAD, gh-rbecheras/refactor-event-handlers, refactor-event-handlers) refactoring event handl
* d6ce122 (gh-rbecheras/bugfix-#210-model-not-saved-after-inserting-images, bugfix-#210-model-not-saved-after-inserting-images) remove unecessa
*   3c499d9 Merge branch 'master' into bugfix-#210-model-not-saved-after-inserting-images                                                      
|\                                                                                                                                             
| * fa0be56 (tag: v0.0.13, gh-upstream/master, master) chore(release): Update versions                
| * da64eb9 Added priority to directive                                                                                                        
* | 61c8e66 Fix #210
|/  
* a5f8d66 bug(model): Touched value now set correctly.
deeg commented 8 years ago

Thanks for posting this PR.

I will look over all of the PRs and try to get the merged later tonight.

deeg commented 8 years ago

@rbecheras, thanks for posting this PR.

I took most of your changes, minus the addition of the SetContent event. Please see my comment on the issue (#210) and we can continue the discussion there.

If it ends up we actually do need SetContent you can open another PR sticking that one in there, with an appropriate test.