search

angular-ui / ui-tinymce

AngularUI wrapper for TinyMCE
MIT License
488 stars 371 forks source link

fix($dirty): check if editor is dirty before updating view #239

Closed MrMartiniMo closed 8 years ago

MrMartiniMo commented 8 years ago

Related Issue: #238 thats my first PR, I hope I haven't messed it up :boom:

deeg commented 8 years ago

Thanks for putting this up. Will take a look over it tonight.

Something that helps us is putting up a plunker with the fix so it is easy for us to test.

Also if you could add a test which verifies your fix that would be great.

MrMartiniMo commented 8 years ago

Plunker with issue: http://plnkr.co/edit/INfZpLpz2yrRvlHitw1N Plunker with fix: http://plnkr.co/edit/As6nkFJPr5bVAd884dRl

I will try to set up a few tests, but it will take some time.

wetternest commented 8 years ago

this fix solves the problem for me, thx for sharing!