search

angular-ui / ui-tinymce

AngularUI wrapper for TinyMCE
MIT License
488 stars 371 forks source link

add optional debouncing #257

Closed douglasg14b closed 8 years ago

douglasg14b commented 8 years ago

Debouncing will no longer be a default action unless the user specifies debounce: true in the options. Relating to issue #256

Motivation: Debouncing was causing unexpected behavior where data was being excluded when submitting or saving text from TinyMCE. Debouncing should be optional.

douglasg14b commented 8 years ago

Conflict: bower ECONFLICT Unable to find suitable version for angular not sure if this has to do with my change?

deeg commented 8 years ago

Thanks for posting this review. I am open to this change.

I will review tonight and try to get all the open PRs merged in. Sorry for the delay.

Don't worry about that error, I can take a look and fix it before merging.

deeg commented 8 years ago

Thanks for the PR. I decided to leave debouncing default for now with the ability to disable it.

I am going to open another ticket to change to throttle and allow debounce to be set by user with ng-model-options.