search

angular-ui / ui-tinymce

AngularUI wrapper for TinyMCE
MIT License
488 stars 371 forks source link

Fix for #264, using the tinymce init promise if available #280

Closed moritzpflaum closed 7 years ago

moritzpflaum commented 8 years ago

I made a plnkr showing the issue: http://plnkr.co/edit/R7oHmGcRkKz5ZZXSFo9h

And one showing it fixed: http://plnkr.co/edit/F1QJlRPN8M04n3yNCgm5

The tests fail because of the line beforeEach(module('ui.tinymce'));

which resets the variable generatedIds to zero before every test, resulting in duplicate ids in the test DOM. If it is replaced with something global, the tests pass. This should not happen in non-test use, I think. I just don't know how to tell jasmine to load the module only once.

timelf123 commented 7 years ago

LGTM, can we merge this?

Nickproger commented 7 years ago

Really need it... Still waiting...

hajderr commented 7 years ago

This one is good. Waiting for it too.

ivorobkalo commented 7 years ago

also waiting

mcblum commented 7 years ago

Need this PR merged if possible!

Edvardoh commented 7 years ago

Waiting for this as well =)

deeg commented 7 years ago

Can you please squash this PR into one commit so I can get it merged in?

asaarnak commented 7 years ago

@deeg i have squashed it in new pull request https://github.com/angular-ui/ui-tinymce/pull/287