Error destroying when closing dialog or navigating in Firefox (47.0.1)

johnwpowell commented 7 years ago

To reproduce Put the editor on a dialog Close the dialog without editing any of the text An error occurs in in the tinyInstance.remove() calls Put the editor on a view Navigate away from the view without making any changes An error occurs in the tinyInstance.remove() calls

The code in the directive is: scope.$on('$destroy', function () { ensureInstance();

              if (tinyInstance) {
                  **tinyInstance.remove();** /// <-- This call errors
                  tinyInstance = null;
              }
          });

          function ensureInstance() {
              if (!tinyInstance) {
                  tinyInstance = tinymce.get(attrs.id);
              }
          }

Stack trace:

calbear47 commented 7 years ago

I am getting the same error under the same circumstances as @johnwpowell, however I only get this exception thrown w/ FireFox 47.x

I believe this thread is related. [https://github.com/tinymce/tinymce/issues/794]

deeg commented 7 years ago

Could you please post a plunker reproducing the issue. From @calbear47's comment it might be an issue with TinyMCE core, and not this library. I could take a closer look if you put up a plunker.

piRstone commented 6 years ago

I had the same issue and updating tinymce and ui-tinymce with the latest versions resolved everything.

angular-ui / ui-tinymce

Error destroying when closing dialog or navigating in Firefox (47.0.1) #282