Expose reload function to adapter to be able to reload manually

angular-ui / ui-utils

Deprecated collection of modules for angular

http://angular-ui.github.io

MIT License

1.43k stars 546 forks source link

Expose reload function to adapter to be able to reload manually #419

Closed flekschas closed 9 years ago

flekschas commented 9 years ago

In my case I am switching the actual data source for datasource in the background and $watching the revision didn't work. Also, $watching is usually more expensive and actually not needed (why would I have to compare variables if I just want to call reload?), thus having the ability to manually call a reload via the adapter is quite helpful. Actually I would remove the revision $watcher but maybe that can be done in another release.

PowerKiKi commented 9 years ago

Please report bug/PR to https://github.com/Hill30/NGScroller

flekschas commented 9 years ago

Interesting. Exactly the same changes have been included 20 days ago. https://github.com/Hill30/NGScroller/commit/bddf8de9fe84225e374db5427cfc38399904f826 So I was late a week.