search

angular / angular-cli

CLI tool for Angular
https://cli.angular.io
MIT License
26.76k stars 11.97k forks source link

Allow globs in `allowedCommonJsDependencies` #18058

Closed muuvmuuv closed 4 years ago

muuvmuuv commented 4 years ago

🚀 Feature request

Command (mark with an x)

Description

With NG10 I have noticed some CommonJS imports and I am now trying to hide some warnings that are save to hide. When I started adding one module name I noticed that I need to be very strict with the path, so importing dayjs/locale/de is not affected by dayjs in allowedCommonJsDependencies, so I needed to add every import twice.

Describe the solution you'd like

Allow globs in allowedCommonJsDependencies (e.g. dayjs/locale/*) or let it know when adding dayjs to allowedCommonJsDependencies that dayjs/locale/de is related to it.

// ...
            "allowedCommonJsDependencies": [
              "dayjs/locale/*", // option A
              "dayjs" // option B
            ],
// ...

Describe alternatives you've considered

Another solution would be to allow ignoring through a comment like eslint rule disabling. I noticed that this would be useful in one case where I add zone.js/dist/zone-error in my environment.ts. With a comment (e.g. @ts-ignore-import) I could ignore the warning here but would still get warnings when someone adds this line accidentally in environment.prod.ts.

// ...
/*
 * For easier debugging in development mode, you can import the following file
 * to ignore zone related error stack frames such as `zone.run`, `zoneDelegate.invokeTask`.
 */
import 'zone.js/dist/zone-error' // @ts-ignore-import
alan-agius4 commented 4 years ago

Another option would be to allow the package instead of the entrypoint.

alan-agius4 commented 4 years ago

From https://github.com/angular/angular-cli/issues/18025#issuecomment-650237123

I would reopen this. The current solution is very inconvenient! We're using lodash in our project and we use synthetic imports to have smaller bundles when importing lodash functions. So we use it like import isEmpty from 'lodash/isEmpty;' and we get a warning per each function and now it's not enough to just say in angular.json 'lodash', but we have to write a long list like "lodash/isEmpty", "lodash/uniqBy", "lodash/get" etc, even though it's just one package in node_modules! We don't want to specify every lodash function we want to use in angular.json just to suppress warning... Would be great if it can be handled per package and not per import.

JohnnyDevNull commented 4 years ago

I have a big list of warnings with DevExtreme Library using the long imports path, please add a glob match pattern like devextreme/*, this is totally bulky in this state.

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\app.component.ts depends on devextreme/localization. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\app.module.ts depends on @angular/common/locales/de. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\app.module.ts depends on @angular/common/locales/en-GB. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\app.module.ts depends on @angular/common/locales/extra/de. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\app.module.ts depends on @angular/common/locales/extra/en-GB. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\projects\sk-core-tester\src\app\pages\dx-overview\dx-overview.component.ts depends on devextreme/ui/dialog. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/ui/toast. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/ui/tabs. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/ui/date_box. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/ui/data_grid. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx-pipes.js depends on lodash. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/data/custom_store. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\dist\sk-core\fesm2015\sk-sk-core-dx.js depends on devextreme/data/data_source. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-button.js depends on devextreme/ui/button. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-core.js depends on devextreme/core/utils/ajax. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-core.js depends on devextreme/events/core/events_engine. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tree-view.js depends on devextreme/ui/tree_view. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tag-box.js depends on devextreme/ui/tag_box. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-drop-down-box.js depends on devextreme/ui/drop_down_box. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-color-box.js depends on devextreme/ui/color_box. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-autocomplete.js depends on devextreme/ui/autocomplete. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-validator.js depends on devextreme/ui/validator. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-validation-summary.js depends on devextreme/ui/validation_summary. CommonJS or AMD dependencies can cause optimization bail
outs.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-validation-group.js depends on devextreme/ui/validation_group. CommonJS or AMD dependencies can cause optimization bailouts
.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-vector-map.js depends on devextreme/viz/vector_map. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tree-map.js depends on devextreme/viz/tree_map. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

mWARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tree-list.js depends on devextreme/ui/tree_list. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tooltip.js depends on devextreme/ui/tooltip. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-bullet.js depends on devextreme/viz/bullet. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-core.js depends on devextreme/events. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-tile-view.js depends on devextreme/ui/tile_view. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-text-area.js depends on devextreme/ui/text_area. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-switch.js depends on devextreme/ui/switch. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-speed-dial-action.js depends on devextreme/ui/speed_dial_action. CommonJS or AMD dependencies can cause optimization bailou
ts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-sparkline.js depends on devextreme/viz/sparkline. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-slider.js depends on devextreme/ui/slider. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-slide-out-view.js depends on devextreme/ui/slide_out_view. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-slide-out.js depends on devextreme/ui/slide_out. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-scheduler.js depends on devextreme/ui/scheduler. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-sankey.js depends on devextreme/viz/sankey. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-recurrence-editor.js depends on devextreme/ui/recurrence_editor. CommonJS or AMD dependencies can cause optimization bailou
ts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-range-slider.js depends on devextreme/ui/range_slider. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-range-selector.js depends on devextreme/viz/range_selector. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-radio-group.js depends on devextreme/ui/radio_group. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-progress-bar.js depends on devextreme/ui/progress_bar. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-polar-chart.js depends on devextreme/viz/polar_chart. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-pivot-grid-field-chooser.js depends on devextreme/ui/pivot_grid_field_chooser. CommonJS or AMD dependencies can cause optim
ization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-pivot-grid.js depends on devextreme/ui/pivot_grid. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-pie-chart.js depends on devextreme/viz/pie_chart. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-nav-bar.js depends on devextreme/ui/nav_bar. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-map.js depends on devextreme/ui/map. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-lookup.js depends on devextreme/ui/lookup. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-linear-gauge.js depends on devextreme/viz/linear_gauge. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-html-editor.js depends on devextreme/ui/html_editor. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-gantt.js depends on devextreme/ui/gantt. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-gallery.js depends on devextreme/ui/gallery. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-funnel.js depends on devextreme/viz/funnel. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-file-uploader.js depends on devextreme/ui/file_uploader. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-file-manager.js depends on devextreme/ui/file_manager. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-drop-down-button.js depends on devextreme/ui/drop_down_button. CommonJS or AMD dependencies can cause optimization bailouts
.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-drawer.js depends on devextreme/ui/drawer. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-diagram.js depends on devextreme/ui/diagram. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-defer-rendering.js depends on devextreme/ui/defer_rendering. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-circular-gauge.js depends on devextreme/viz/circular_gauge. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-chart.js depends on devextreme/viz/chart. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-bar-gauge.js depends on devextreme/viz/bar_gauge. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:\lvs\git\sk.sk-core.lib-ng-dx\node_modules\devextreme-angular\fesm2015\devextreme-angular-ui-accordion.js depends on devextreme/ui/accordion. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
jimmykane commented 4 years ago

Ok is there anywhere we can complain about this warnings ?

This is completely rediculus.

From one issue and to the other to figure out how even angularfire / material and many others offer this warming.

Should we go more public about this with high social profiles ?

What the hell angular team??

This was not even in the upgrade guide.

It's the first time since angular 2 that actually updating broke things.

Can someone guide me where to track these issues with warnings? (

petebacondarwin commented 4 years ago

@jimmykane :

It's the first time since angular 2 that actually updating broke things

Please note that these are warnings, not breakages. So this upgrade has not broken anything.

Moreover in the case of firebase, it is actually helping you. Previously you have unwittingly been using libraries that are packaged in a way that potentially are making your production bundles larger than they need to be.

jimmykane commented 4 years ago

How exactly is it helping me if it's not documented in the upgrade guide ?

Post upgrade and start searching ?

This is the definition of a bad upgrade procedure.

JohnnyDevNull commented 4 years ago

How exactly is it helping me if it's not documented in the upgrade guide ?

Post upgrade and start searching ?

This is the definition of a bad upgrade procedure.

I would say it more friendly that this feature is not designed for real world applications.

jimmykane commented 4 years ago

@JohnnyDevNull ? What do you mean with not designed for real world applications ?

Are you using some imaginary world applications at your company ? If so how ? Enlighten me. Perhaps I need to get back to the matrix our investors and our clients.

angular-automatic-lock-bot[bot] commented 4 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.