angular / angular-cli

CLI tool for Angular
https://cli.angular.dev
MIT License
26.79k stars 11.98k forks source link

Angular builders - more complex testing examples #23297

Open klemenoslaj opened 5 years ago

klemenoslaj commented 5 years ago

πŸ“š Docs or angular.io bug report

Description

There is already a pretty good documentation in regards to Angular CLI Builders, however, I get stuck right after trying something more complex than triggering a simple command.

I am extending the existing @angular-devkit/build-ng-packagr builder, so that certain logic is executed after the packagr builder is done. That all works fine, however I don't know how to test it correctly.

I tried to create a fake workspace, where I would run my builder, but obviously that fails due to absence of dependencies, like @angular/core.

I as well tried to look into official builder itself where I found that bunch of deprecated API is used, therefore did not proceed there.

πŸ”¬ Minimal Reproduction

What's the affected URL?**

https://next.angular.io/guide/cli-builder

Reproduction Steps**

This can of course be fixed by creating package.json and installing @angular/core in the fake workspace, but is this the right way?

πŸ”₯ Exception or Error

Building Angular Package
Building entry point 'lib'
Compiling TypeScript sources through ngc

BUILD ERROR
Could not resolve module @angular/core
Error: Could not resolve module @angular/core
    at StaticSymbolResolver.getSymbolByModule (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_symbol_resolver.ts:521:11)
    at StaticReflector.findDeclaration (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:111:29)
    at StaticReflector.initializeConversionMap (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:367:14)
    at new StaticReflector (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:69:10)
    at Object.createAotCompiler (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/compiler_factory.ts:67:7)
    at AngularCompilerProgram._createCompiler (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:651:22)
    at AngularCompilerProgram.get [as hostAdapter] (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:531:12)
    at AngularCompilerProgram._createProgramWithBasicStubs (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:690:71)
    at /Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:240:17

kapunahelewong commented 4 years ago

Status: docs team will need to work with engineering to create more complex examples ensuring that we explain the pertinent points.

angular-robot[bot] commented 3 years ago

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] commented 3 years ago

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.