angular / angular-cli

CLI tool for Angular
https://cli.angular.io
MIT License
26.74k stars 11.98k forks source link

ng serve <project> runs tslint and fails. #26669

Closed brianpilati closed 9 months ago

brianpilati commented 9 months ago

Command

serve

Is this a regression?

The previous version in which this bug was not present was

No response

Description

When I run `ng serve I get tslint errors and I do not have tslint installed.

Minimal Reproduction

angular.json file

{
  "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
  "version": 1,
  "newProjectRoot": "projects",
  "projects": {
    "project": {
      "root": "",
      "sourceRoot": "src",
      "projectType": "application",
      "prefix": "app",
      "schematics": {},
      "architect": {
        "lint": {
          "builder": "@angular-eslint/builder:lint",
          "options": {
            "eslintConfig": ".eslintrc.json",
            "lintFilePatterns": [
              "src/app/**/*.ts",
              "src/app/**/*.html"
            ]
          }
        }
      }
    },

.eslintrc.json file

{
  "extends": "../../.eslintrc.json",
  "ignorePatterns": ["!**/*"],
  "overrides": [
    {
      "files": ["*.ts"],
      "parserOptions": {
        "project": ["projects/<project>/tsconfig.lib.json", "projects/<project>/tsconfig.spec.json"],
        "createDefaultProgram": true
      },
      "rules": {
        "@angular-eslint/directive-selector": [
          "error",
          {
            "type": "attribute",
            "prefix": "subscription",
            "style": "camelCase"
          }
        ],
        "@angular-eslint/component-selector": [
          "error",
          {
            "type": "element",
            "prefix": "subscription",
            "style": "kebab-case"
          }
        ]
      }
    }
  ]
}

Exception or Error

ng serve <project>
One or more browsers which are configured in the project's Browserslist configuration will be ignored as ES5 output is not supported by the Angular CLI.
Ignored browsers: kaios 2.5, op_mini all
✔ Browser application bundle generation complete.

Initial Chunk Files                       | Names                       |  Raw Size
main.js                                   | main                        |   5.23 MB |
styles.css, styles.js                     | styles                      | 456.93 kB |
polyfills.js                              | polyfills                   | 333.25 kB |
runtime.js                                | runtime                     |  13.00 kB |

                                          | Initial Total               |   6.01 MB

Lazy Chunk Files                          | Names                       |  Raw Size
src_app_library_subscription_module_ts.js | library-subscription-module |   5.65 MB |

Build at: 2023-12-13T21:20:18.163Z - Hash: 72741e91022f2816 - Time: 16736ms

Error: src/testing/class/account.invoice.test.class.ts:32:38 - error TS7030: Not all code paths return a value.

32   getSearchInterceptor(url: string): any[] {
                                        ~~~~~
 ... 

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

✖ Failed to compile.

Your Environment

Angular CLI: 16.2.10
Node: 16.20.2
Package Manager: npm 8.19.4
OS: darwin x64

Angular: 16.2.12
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, material, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1602.10
@angular-devkit/build-angular   16.2.10
@angular-devkit/core            16.2.10
@angular-devkit/schematics      16.2.10
@angular/cli                    16.2.10
@angular/flex-layout            15.0.0-beta.42
@schematics/angular             16.2.10
ng-packagr                      16.2.3
rxjs                            7.8.1
typescript                      5.1.6
zone.js                         0.13.3

Anything else relevant?

No response

JeanMeche commented 9 months ago

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular.

If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.

brianpilati commented 9 months ago

@JeanMeche Is this a feature? Is tslint supposed to run with ng serve?

JeanMeche commented 9 months ago

TS7030 is not a tslint error but a typescript compiler error.

So yes, this is expected.

brianpilati commented 9 months ago

Ah, yes. So I need to update my tsconfig.json file to not include that directory when building?

brianpilati commented 9 months ago

@JeanMeche Thanks for your help that was all that I need. I'm sorry to waste your time.

angular-automatic-lock-bot[bot] commented 8 months ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.