angular / angular-cli

CLI tool for Angular
https://cli.angular.io
MIT License
26.66k stars 11.98k forks source link

Supporting Tailwind v4 #27585

Open inorganik opened 2 months ago

inorganik commented 2 months ago

Command

build

Is this a regression?

The previous version in which this bug was not present was

No response

Description

Tailwind v4 alpha is out and a stable release is imminent. The new CLI @tailwindcss/cli traverses files in your project and automatically finds the tailwind classes. It works without a tailwind config, which is what the angular builder looks for to support tailwind. The problem is, you have to setup an npm script to invoke the tailwind CLI, and it is seemingly impossible to integrate it into Angular's build process. I've tried lots of weird hacky things.

Alternatively, Tailwind v4 offers a new postcss plugin, but again, there is no way to configure post css in Angular.

Other issues with using Tailwind v4 in an Angular project:

We ought to be able to use the latest and greatest in our Angular projects. As a start we should remove the peer dependency on old versions of tailwind.

We ought to decouple tailwind integration out of this package so it can be configurable by devs.

Minimal Reproduction

I have an angular 16 project here with tailwind v4 installed, you have to use the --force flag to install dependencies because of the incompatible tailwind peer dep. An npm script "tailwind" has to be run separately from the build, so for every style change you have to rerun the command.

Exception or Error

No response

Your Environment

v16 and v17

Anything else relevant?

No response

alan-agius4 commented 2 months ago

The Angular application builder supports custom PostCSS configuration files. The builder will automatically detect and use specific postcss configuration files if present in either the project root directory or the workspace root.

To utilize a custom PostCSS configuration:

  1. Create a JSON file named either postcss.config.json or .postcssrc.json in your project's root directory. Project-level configurations override workspace-level ones.

  2. Define your plugins within this file using either an array or object format:

    Array Form:

    {
     "plugins": [
       "tailwindcss",
       ["rtlcss", { "useCalc": true }]
     ]
    }

    Object Form:

    {
     "plugins": {
       "tailwindcss": {},
       "rtlcss": { "useCalc": true }
     }
    }
inorganik commented 2 months ago

Thanks @alan-agius4 ! In this comment I had read postCSS config wasn't supported but glad to be wrong about that.

Following these instructions unfortunately I was not able to get v4 working. Here is my postcss.config.json file at the root of my project:

{
  "plugins": {
    "@tailwindcss/postcss": {}
  }
}

The plugin name is from the tailwind docs. I'm not seeing any error messages, but it is not compiling tailwind either. I pushed these changes to the postcss branch of my test repo

alan-agius4 commented 2 months ago

@inorganik, custom postcss configuration is only available from Angular CLI versions 17.2 onwards.

inorganik commented 2 months ago

@alan-agius4 The postcss config works great in Angular 17! Only issue now is the peer deps - is there a way to not have to use the force flag for every npm install/build?

alan-agius4 commented 1 month ago

You can add legacy-peer-deps=true to an .npmrc file located in your workspace.

dgp1130 commented 3 weeks ago

We had a brief discussion within the team about this today. There's nothing too controversial here just a few different tasks we'll need to land. Tailwind v4 is still in alpha, so I don't think there's anything urgent here, but once it does release we'll want to:

Angular still uses the presence of a Tailwind config file to know whether or not we need to run Tailwind. That probably won't change even in v4, even if Tailwind itself no longer requires a config file.

angular-robot[bot] commented 2 weeks ago

This feature request is now candidate for our backlog! In the next phase, the community has 60 days to upvote. If the request receives more than 20 upvotes, we'll move it to our consideration list.

You can find more details about the feature request process in our documentation.