angular / angular-cli

CLI tool for Angular
https://cli.angular.dev
MIT License
26.78k stars 11.98k forks source link

Compatibility with Dart Sass >=1.79 #28804

Closed emily-mikl-fcb-com closed 1 week ago

emily-mikl-fcb-com commented 1 week ago

Which @angular/* package(s) are the source of the bug?

compiler

Is this a regression?

No

Description

Since Dart Sass 1.79 the functions color.red(), color.green(), and color.blue() have been deprecated in favor of using color.channel(). (See official Sass docs.) However, when making that update in our Angular 18 project we get an error: Image

But Dart Sass will give an error if we use the old way: Image

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 18.2.0 Node: 20.18.0 Package Manager: npm 10.9.0 OS: win32 x64

Angular: 18.2.0 ... animations, cli, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1802.0 @angular-devkit/build-angular 18.2.0 @angular-devkit/core 18.2.0 @angular-devkit/schematics 18.2.0 @angular/cdk 18.2.3 @schematics/angular 18.2.0 rxjs 7.8.1 typescript 5.5.4 zone.js 0.14.10

Anything else?

No response

JoostK commented 1 week ago

What is the output of npm ls sass? The package.jsonof @angular-devkit/build-angular lists sass 1.77.6, so that is the version that the CLI is expected to use, not >=1.79.

emily-mikl-fcb-com commented 1 week ago

OK that makes sense! Since we were using "sass": "^1.60.0" in our package.json in the scss-lib, it automatically pulled in version 1.80.0. I've changed it to explicitly pull in the same version as the Angular application so now it's matching. Thank you!