angular / angular-es

Localization of angular.io to Spanish
MIT License
21 stars 27 forks source link

Main Navbar Translation #40

Closed baruchvlz closed 8 years ago

baruchvlz commented 8 years ago

Translate the main nav partial. I'm not 100% sold on Features being translated to Características but I couldn't find a better word in the thesaurus.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


baruchvlz commented 8 years ago

Signed!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

baruchvlz commented 8 years ago

Signed with correct email.

baruchvlz commented 8 years ago

@Foxandxss Hey Jesús, how can I fix my CLA?

Foxandxss commented 8 years ago

You need to amend your commit to use your account.

First check that your git in your machine has your username and email.

Then you can change the author of your commit.

You can do `git commit --amend --autor="Your name your@email.com"

Then force push to your fork and branch.

And important, don't use your master, create a branch for each new PR.

baruchvlz commented 8 years ago

Thanks for explaining. You think it's better to close this and I'll open a new PR with the correct email and branch?

Foxandxss commented 8 years ago

That works too.