search

angular / angular-hint

run-time hinting for AngularJS applications
363 stars 45 forks source link

fix(scopes) check all scopes for changes on apply #104

Closed gary-b closed 9 years ago

gary-b commented 9 years ago

When scope.apply() was called model:change events were only sent out for the current scope. This meant any updates to inherited properties would not be reflected in Batarang. It also meant any changes to objects that were referenced by multiple scopes would only be updated for the current scope. This would be a relatively common scenario, eg where the page's model is kept in a service and multiple controllers / directives on screen display various elements of it. Since the scopes that share common objects may live outside each others prototype chains, checking for changes in all scopes and paths currently watched. Hopefully the currently watched qualifier here limits the performance impact.

Fixes angular/batarang#201

gary-b commented 9 years ago

It looks like angular/batarang#81 was about this same problem too.

Third comment down though, mik01aj referenced what I think is a separate issue altogether regarding the elements pane.

SomeKittens commented 9 years ago

:shipit:

btford commented 9 years ago

Looks good to me!