fix(scopes): don't break one time ngbind expressions

angular / angular-hint

run-time hinting for AngularJS applications

362 stars 45 forks source link

fix(scopes): don't break one time ngbind expressions #107

Closed erwinmombay closed 8 years ago

SomeKittens commented 8 years ago

Code LGTM, lemme pull that down and run tests locally since Travis is funky.

SomeKittens commented 8 years ago

Getting this failure with Karma

Chromium 44.0.2403 (Ubuntu 0.0.0) ngHintScopes scope.$watch should not run perf timers for one time bind expressions FAILED
    TypeError: Cannot read property 'eventType' of undefined
        at Object.<anonymous> (/home/somekittens/Dropbox/angular/hint/test/scopes.spec.js:65:19)

erwinmombay commented 8 years ago

thanks for checking. will look into it and write some tests.

SomeKittens commented 8 years ago

Yep, update fixed tests. Landed in 0b98cfacc62247b0ceed46c523385e588a55190d