search

angular / angular-hint

run-time hinting for AngularJS applications
362 stars 45 forks source link

fix(modules): Don't re-register modules we've seen before #113

Closed SomeKittens closed 8 years ago

SomeKittens commented 8 years ago

When recursively tracking modules, we will hit a stack overflow if two modules depend on each other. Track modules we've seen and don't re-register them if we've seen them before.

Fixes https://github.com/angular/batarang/issues/200

SomeKittens commented 8 years ago

I was unable to reproduce the problem in Batarang 200, but this should fix it.

sjurba commented 8 years ago

I have confirmed this fix, and it solves my problem with stack overflow.

erwinmombay commented 8 years ago

LGTM!

SomeKittens commented 8 years ago

Brought in via c91ef9e4d8d32b9488b5c8c7bf9ce5aa78e1902a