angular / angular-hint

run-time hinting for AngularJS applications
362 stars 45 forks source link

ddLib is not defined #13

Closed ealtenho closed 10 years ago

ealtenho commented 10 years ago

I think there is an issue with the loading of dependencies for the angular-hint-directives module. When I run the sample app to test the bootstrapping and I load the angular-hint-directives module I get the error:

message
"[$injector:modulerr] Failed to instantiate module ng due to:
ReferenceError: ddLib is not defined
    at $CompileProvider.angular.module.config.$provide.provider.provider.directive (http://localhost:8080/dist/hint.js:97:28)
    at ngModule (http://localhost:8080/bower_components/angular/angular.js:2009:9)
    at Object.invoke (http://localhost:8080/bower_components/angular/angular.js:3906:17)
    at http://localhost:8080/bower_components/angular/angular.js:3824:37
    at Array.forEach (native)
    at forEach (http://localhost:8080/bower_components/angular/angular.js:320:11)
    at loadModules (http://localhost:8080/bower_components/angular/angular.js:3811:5)
    at createInjector (http://localhost:8080/bower_components/angular/angular.js:3751:11)
    at doBootstrap (http://localhost:8080/bower_components/angular/angular.js:1410:20)
    at Object.angular.resumeBootstrap (http://localhost:8080/bower_components/angular/angular.js:1433:5)
http://errors.angularjs.org/1.2.18/$injector/modulerr?p0=ng&p1=ReferenceErr…2F%2Flocalhost%3A8080%2Fbower_components%2Fangular%2Fangular.js%3A1433%3A5)"

@caguillen214 @btford does this have to do with loading the dependencies through browserify? Or is there an issue with the module itself?

caguillen214 commented 10 years ago

I dont think there is an issue with the module it's self because it works independently, so I can only imagine it's browserify

ealtenho commented 10 years ago

This issue had to do with angular-hint-directives not loading its own dependency ddLib. I altered this in https://github.com/angular/angular-hint-directives/commit/e3fa3c4132b6a6461c41b0eb2fbb510042efe48d. @caguillen214, I also made some small changes to naming and structure in order to make angular-hint-directives similar to our other modules.