make use of ngHintLog pipeline to deliver messages to the user

angular / angular-hint

run-time hinting for AngularJS applications

362 stars 45 forks source link

make use of ngHintLog pipeline to deliver messages to the user #27

Closed ealtenho closed 9 years ago

ealtenho commented 9 years ago

Currently ngHintLog in each of the modules is collecting messages. This can be seen in the e2e tests that use hintLog.onMessage to put messages into a console div. AngularHint to should use this pipeline to provide these messages to the user. Should these messages be in console.groupCollapsed? https://github.com/angular/angular-hint-log/issues/7

btford commented 9 years ago

Yes, if the browser supports it.

ealtenho commented 9 years ago

Update modules to new logging syntax:

[x] Hint Controllers (339e80949db2568dd7771450a9d0755c92aa04ce)
[x] Hint DOM (f957b46142ab42bef596626d31da16b51a508e19)
[x] Hint Events (74ddf3f76b10803414b0aa06ae7532b7ef99d218)
[x] Hint Directives (5aafffe1316d028acf7e2c8c11df863358eaad76)
[x] Hint Modules (a59ff7f7a25300c754f02b28816cdfe3415feaa6)
[x] Hint Interpolation (144bbdf46bade19aa65de43432fe30685ad1202c)

ealtenho commented 9 years ago

@caguillen214 Let me know when you've finished the tests for hintModules so I can include the updated version in my ngHint tests.

ealtenho commented 9 years ago

As of https://github.com/angular/angular-hint/commit/a59ff7f7a25300c754f02b28816cdfe3415feaa6, all existing hintModules use HintLog v0.2.0. AngularHint logs the collected messages in the HintLog queue using the flush method to groups using console.groupCollapsed.