angular / angular-hint

run-time hinting for AngularJS applications
362 stars 45 forks source link

Latest ngHintLog improvements #33

Closed ealtenho closed 9 years ago

ealtenho commented 9 years ago

@caguillen214 ngHintLog is up to v0.3.0 which means that individual modules must be updated again. This is likely to affect unit tests as it strips an unnecessary leading space that was being added to queued messages. Hence any unit tests that look for output from hintLog.flush() need to be rewritten to remove this space. I'm wondering if in the package.json for the various modules it would now make sense to use 'angular-hint-log: >=0.3.0' rather than strictly 'angular-hint-log: 0.3.0' because of this installation cost for each module. I believe this would allow the version of angularHintLog loaded by angularHint to override that of the individual module if it is newer. However, it could later cause problems if a newer version of ngHintLog introduces a breaking change and individual modules are not updated correctly.

ealtenho commented 9 years ago

Okay... so before these have been updated to v0.3.0 @caguillen214 will probably refactor and update HintLog to v0.4.0 so that HintLog messages can be categorized for severity to provide a more detailed output in our AngularHintUI.

@caguillen214 update this issue please when HintLog v0.4.0 is available so that we can start updating the modules.

ealtenho commented 9 years ago

Published modules with v0.4.0 of hintLog ->