search

angular / angular-hint

run-time hinting for AngularJS applications
362 stars 45 forks source link

bug(scopes): fix scope decorator to not break one time binding #83

Closed erwinmombay closed 9 years ago

erwinmombay commented 9 years ago

since we patch $watch to be able to run performance timers, we always pass a function to the original $watch which in turn passes it to $parse where only string expressions is allowed to be a one time binding which means our patch breaks one time binding expressions. Skip one perf timers for one time binding since it isn't too helpful anyways since its only a one time bind.

We will ask the angular team for some introspection hooks and a strict mode so that we don't have to keep on patching angular core methods to be able to run perf timers.

fixes: https://github.com/angular/angularjs-batarang/issues/209

erwinmombay commented 9 years ago

feature request to angular.js 1.x https://github.com/angular/angular.js/issues/11844

erwinmombay commented 9 years ago

@SomeKittens mind reviewing? Thanks!

SomeKittens commented 9 years ago

Merged in 7230c9a77440c283673d8b4e35719f873587fac9