search

angular / angular-hint

run-time hinting for AngularJS applications
362 stars 45 forks source link

fix(Module): Differentiate between get and set #86

Closed mattlavallee closed 9 years ago

mattlavallee commented 9 years ago

Module did not differentiate between a get and set of the module resulting in incorrect errors about a module being defined more than once

SomeKittens commented 9 years ago

Thanks! Ran into this last night with Batarang tests, so this is a wonderfully timely PR. Code looks good (tests would be helpful though). I'll check it out further tonight (PST).

mattlavallee commented 9 years ago

Roger that. I'll try to get those tests up soon

erwinmombay commented 9 years ago

@mattlavallee let us know if you need any help on the tests. we're more than happy to help :+1:

mattlavallee commented 9 years ago

Sorry about the delay. I'm having trouble getting gulp to actually do anything on my machine (and getting karma to actually be recognized) so I've been troubleshooting those issues :-\

SomeKittens commented 9 years ago

@mattlavallee no rush. There's a few other fixes that are taking longer than expected.

mattlavallee commented 9 years ago

Sorry for the crazy delay...just got back from vacation. I finally got gulp/karma working locally.

I've added a UT for my patch

SomeKittens commented 9 years ago

Cherry-picked into master, thanks! Great find.

In the future, would you mind rebasing commits down to one commit?

mattlavallee commented 9 years ago

Of course. I was just holding off on the rebase in case other changes were needed.