Scope id not sent with scope:destroy message

angular / angular-hint

run-time hinting for AngularJS applications

362 stars 45 forks source link

Scope id not sent with scope:destroy message #90

Closed gary-b closed 9 years ago

gary-b commented 9 years ago

There is an issue with Batarang in which scopes are never deleted from the scope tree. This is caused (in part) because the id of the scope isn't passed through from ngHint. I have not got the SauceLabs tests setup locally. I presume these are executed automatically anyway by the CI server. A PR for Batarang with the rest of the changes required to fix this bug is incoming.

SomeKittens commented 9 years ago

:+1: Will bring in when I get back home.

SomeKittens commented 9 years ago

Well, this is embarrassing. Thanks for the fix.

Landed in: c1050f855fae58c1766f828a201fae5eb41c7449