search

angular / angular-seed

Seed project for angular apps.
http://angularjs.org/
MIT License
13.03k stars 6.93k forks source link

chore(*): switch from `bower` to `npm` for frontend dependencies #390

Closed petebacondarwin closed 6 years ago

petebacondarwin commented 7 years ago

A tweak to #389

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

alexandernst commented 7 years ago

Is this ready to be merged?

gkalpak commented 7 years ago

Not yet (but it's close) :smiley:

alexandernst commented 7 years ago

How about now? Is it ready? What is missing?

Natanagar commented 7 years ago

I use your code to create templates in my project, I hope you allow?

petebacondarwin commented 7 years ago

I guess we should switch it to yarn not npm?

gkalpak commented 7 years ago

I don't know. This adds an extra dependency (because npm typically comes "bundled" with node). Since this is a seed project, it might be better to be less opinionated. So, I slightly lean towards npm, but don't feel too strongly about it. (Obviously, either is better than using bower :grin:)

petebacondarwin commented 7 years ago

I have tweaked and squashed. PTAL

binki commented 6 years ago

As asked earlier, is this ready now?

petebacondarwin commented 6 years ago

I don't think this is going to land now that we are in LTS mode.

gkalpak commented 6 years ago

Rolled into #444.