Closed gkalpak closed 5 years ago
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google
commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla
label to yes
(if enabled on your project), and then merge this pull request when appropriate.
Not sure why Travis isn't triggered. I verified this on my fork: https://travis-ci.org/gkalpak/angular-seed/builds/446783519
why rename the folder
components
tocore
?
@petebacondarwin See #334.
fixup
commits and also switched to Chrome headless on CI.@petebacondarwin, @mgol: PTAL
Looks like Travis is not enabled for this repo - it must have been disabled some time in the last year: https://travis-ci.org/angular/angular-seed (says "This is not an active repository" for me)
And we don't have rights to turn it back on...
Main themes:
Incorporates #361 and #390. Partially addresses #334.