search

angular / angular-seed

Seed project for angular apps.
http://angularjs.org/
MIT License
13.04k stars 6.95k forks source link

chore(*): refactor, improve, upgrade #444

Closed gkalpak closed 5 years ago

gkalpak commented 5 years ago

Main themes:

Incorporates #361 and #390. Partially addresses #334.

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

gkalpak commented 5 years ago

Not sure why Travis isn't triggered. I verified this on my fork: https://travis-ci.org/gkalpak/angular-seed/builds/446783519

mgol commented 5 years ago

why rename the folder components to core?

@petebacondarwin See #334.

gkalpak commented 5 years ago

@petebacondarwin, @mgol: PTAL

Narretz commented 5 years ago

Looks like Travis is not enabled for this repo - it must have been disabled some time in the last year: https://travis-ci.org/angular/angular-seed (says "This is not an active repository" for me)

petebacondarwin commented 5 years ago

And we don't have rights to turn it back on...