search

angular / angular.js

AngularJS - HTML enhanced for web apps!
https://angularjs.org
MIT License
58.85k stars 27.52k forks source link

nested svg directives doesn't work in FF (31.0) and Safari #10553

Closed albertzang closed 7 years ago

albertzang commented 9 years ago

Hi all,

I'm trying to draw a gobang board with 'svg'. My code on plunker: http://plnkr.co/edit/znkQzCZSPQnckrO4d6gY

It works as expected on Chrome. So if you run it on Chrome, you will know what I'm trying to do. But somehow the 'gbCircle' directive doesn't render properly on FF.

Do I use directives incorrectly somewhere here? Or this is a bug?

Thank you my genius!

caitp commented 9 years ago

screen shot 2014-12-22 at 2 26 39 pm (this is roughly identical to what I see in Chrome)

looks like it's working to me, in chrome and FF --- but not working in safari

albertzang commented 9 years ago

Hi caitp, if you hover the cross of lines on board, you should see circles coming out. The board is drawing fine on both FF and Chrome.

You mean you can see circles when you hover intersections on FF? I'm running FF 31.0 on Ubuntu 14.04.

caitp commented 9 years ago

I do see the circles when I hover over intersections (FF 37)

screen shot 2014-12-22 at 2 38 17 pm

albertzang commented 9 years ago

Yea caitp, I just saw your attached image. That's what I'm expecting. All 'gbCircle' render at (0, 0) with 0 radius on my FF though. Don't know why.

Seems so far a FF bug to me.

albertzang commented 9 years ago

Thank you for the screenshots caitp! :)

caitp commented 9 years ago

So it's broken in V33.0.1, and V34.0.5, but seems to have been subsequently fixed. I don't know if we can fix this from Angular, because we're already doing just about everything we can to make sure namespaced items are created correctly.

The best thing to do might be to wait for the fixed version to be released as stable

albertzang commented 9 years ago

Thank you for testing my little plunker on these browsers Caitlin. At least now I know that I'm not using directives incorrectly.

Feel free to close this issue if this is not a Angular bug.

caitp commented 9 years ago

my gut feeling is that it's another SVG innerHTML not-working-correctly bug, but it's hard to verify. I'll leave this open until january unless someone else closes it

albertzang commented 9 years ago

Thanks :+1:

Narretz commented 8 years ago

I've tested this against Safari 9 and the bug is fixed. I doubt that we will fix it for Safari 8, but I'll leave it open anyway.

Narretz commented 7 years ago

Another year means even fewer people on Safari 8, so I'm closing this. ;)