angular / angular.js

AngularJS - HTML enhanced for web apps!

https://angularjs.org

MIT License

58.85k stars 27.52k forks source link

jqLite off/unbind leaking event handlers #6685

Closed g00fy- closed 10 years ago

g00fy- commented 10 years ago

plunkr showing native removeEventListener (no leaks) vs jqLite.unbind: http://plnkr.co/edit/VPfdAMITaqAWNGIZ1eQL?p=preview in the provided example jqLite.unbind does not remove event listeners. Note: elements are pushed to window.elements on purpose to simulate more advanced use cases

thebigredgeek commented 10 years ago

I must be missing something. How exactly does this demo show your claim?

g00fy- commented 10 years ago

@thebigredgeek

leaking (leaves event handlers): leaking

native (removes event handlers): native

see the event listeners graph. I am suprised that even native doesn't drop to 4 handlers - on other machine the native version drops to 4 (0) event handlers

SekibOmazic commented 10 years ago

5270

lefos987 commented 10 years ago

Thank you for reporting this but as you can see from #5270 this not an actual issue. Closing it but if you still face issues let us know