angular / angular

Deliver web apps with confidence 🚀
https://angular.dev
MIT License
95.93k stars 25.36k forks source link

[commit conventions] Make `:` after `BREAKING CHANGE` optional #4114

Closed gr2m closed 8 years ago

gr2m commented 9 years ago

Hey,

I've already run into this several times. I usually do breaking change commits like this

BREAKING CHANGE

Before

    var Server = require('kazana-server')

    var kazana = new Server('path/to/kazana-app-or-plugin')
    kazana.start(function () {
      console.log('Server running at %s', kazana.info.uri)
    })

Now

    var startKazanaServer = require('kazana-server')

    startKazanaServer('path/to/kazana-app-or-plugin', /*options ,*/ function (error, server) {
      if (error) {
        throw error
      }
      console.log('Server running at %s', kazana.info.uri)
    })

I tend to forget the : because I do line breaks instead. Any chance we could make the : optional?

This is causing quite some headaches for me, because I use semantic-release everywhere, (which uses https://github.com/ajoslin/conventional-changelog, which strictly implements angular commit messages), and end up with minor releases on GitHub/npm, but with breaking changes :(

Thanks :bouquet:


follow up for https://github.com/ajoslin/conventional-changelog/issues/103, cc @jo

vicb commented 8 years ago

@jeffbcross is this fixed with the conventional changelog update ?

vicb commented 8 years ago

seems like this is not fixed yet....

https://github.com/conventional-changelog/conventional-commits-parser/blob/61d3809e6d95a52922172c6ecaace9f3c91cc39d/lib/regex.js#L21

vicb commented 8 years ago

fixed

angular-automatic-lock-bot[bot] commented 5 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.