angular / angular

Deliver web apps with confidence 🚀
https://angular.dev
MIT License
94.71k stars 24.68k forks source link

Remove unused JSNAMESPACE_SUPPORT from event-dispatch #55619

Closed rahatarmanahmed closed 1 week ago

rahatarmanahmed commented 2 weeks ago

This was an old feature that let you add jsnamespace="ns to an element to implicitly add the ns. namespace to all unnamespaced JSAction handlers on or under that element. This required an expensive DOM walk to find the jsnamespace, and almost all JSAction users turned this feature off. The last usage in google 3was removed, so we can delete this now.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

rahatarmanahmed commented 2 weeks ago

Caretaker note: cl/630174160 is needed either in sync CL or prior to sync CL due to copybara changes.

rahatarmanahmed commented 1 week ago

TESTED=TGP (failures are extremely flaky and fail at HEAD)

AndrewKushnir commented 1 week ago

Caretaker note: this PR is ready for merge, the only missing piece was an additional public-api approval, but since this is a removal of a no longer used feature, existing approvals should be sufficient.

AndrewKushnir commented 1 week ago

This PR was merged into the repository by commit 879537466ea1d8485599176f4a7cb2d0d81ac870.