angular / angular

Deliver web apps with confidence 🚀
https://angular.dev
MIT License
94.71k stars 24.68k forks source link

fix(core): afterRender hooks registered outside change detection can … #55623

Closed atscott closed 2 weeks ago

atscott commented 2 weeks ago

…mark views dirty

This commit fixes an error in the looping logic of ApplicationRef.tick when the tick skips straight to render hooks. In this case, if a render hook makes a state update that requires a view refresh, we would never actually refresh the view and just loop until we hit the loop limit.

atscott commented 2 weeks ago

caretaker note: g3 failures are unrelated

AndrewKushnir commented 2 weeks ago

This PR was merged into the repository by commit 7c1b4a49ae3f99b775dc786666bd14997fa43438.