refactor(docs-infra): notify on data change inside OnPush component

angular / angular

Deliver web apps with confidence 🚀

https://angular.dev

MIT License

94.88k stars 24.76k forks source link

refactor(docs-infra): notify on data change inside OnPush component #55830

Closed pkozlowski-opensource closed 1 week ago

pkozlowski-opensource commented 2 weeks ago

The SecondaryNavigation component was updating state outside of an event handler without notifying about this change. Modeling state as signal should take care of proper UI updates (note that I did just a mechanical change here, maybe there are better ways of dealing with this animations case).

dylhunn commented 1 week ago

This PR was merged into the repository by commit 831a20b472e5f5f7c96f8b78aaeb775db42c421d.