signals (or function calls in the templates) in language service

[eneajaho]

Which @angular/* package(s) are relevant/related to the feature request?

language-service

Description

1. Quick Info for signal works only if that signal is a field of the component

While for some signal in a service it's not working (it doesn't get the definition)

• A normal property of an object works fine
• A property as a signal doesn't work (it doesn't get the definition)

2. Calling a method in the template doesn't work (doesn't go to definition)

These are either issues with function calling or getting the correct definition for function calls in the template.

Tested with this code:

import { Component, Injectable, inject, signal } from '@angular/core';

@Injectable()
export class SomeService {
  someSignal = signal(0);

  someMethod() {
    console.log('hello world!');
  }
}

@Component({
  selector: 'app-root',
  standalone: true,
  template: `
    <div>{{ someProp }}</div>
    <div>{{ someSignal() }}</div>
    <div>{{ someService.someSignal() }}</div>

    <div>{{ someObject.someProp }}</div>
    <div>{{ someObject.someSignalProp() }}</div>

    <button (click)="someSignal.set(1)">Increment</button>
    <button (click)="someService.someSignal.set(1)">Increment Service</button>
    <button (click)="someObject.someSignalProp.set('hello world!')">Change Object</button>

    <button (click)="someService.someMethod()">Call Service Method</button>
  `,
})
export class AppComponent {
  someService = inject(SomeService);

  someProp = 'hello world!';
  someSignal = signal(0);

  someObject = {
    someSignalProp: signal('hello world!'),
    someProp: 'hello world!',
  }
}

Proposed solution

Add better handling for function calls in language-service

Alternatives considered

-

[eneajaho]

I'd also like to try to work on this one.

[eneajaho]

Looks like getSymbolOfNode doesn't return any result at all

it('should work for accessed function calls', () => {
  expectQuickInfo({
    templateOverride: `<div (click)="someObject.some¦Method()"></div>`,
    expectedSpanText: 'someMethod',
    expectedDisplayString: '(property) someMethod: () => number',
  });
});

[alxhub]

This seems like a bug (or set of bugs), not a feature request.