search

angular / angular2-seed

MIT License
1.01k stars 640 forks source link

Simplify seed project installation with Dockerfile option #140

Closed jamesbyars closed 6 years ago

PatrickJS commented 7 years ago

why have package.json in config/?

jamesbyars commented 7 years ago

When running in a container you have to bind the host to 0.0.0.0.

pkozlowski-opensource commented 7 years ago

Honestly I would prefer that we keep docker out of this seed. It is meant to be a simple (or simplest possible) and I would like it to stay this way. There are many other elaborate starter kits where docker option might makes sense.

All it to say that I would for not merging this PR.

jamesbyars commented 7 years ago

I understand your concern. I created it because I had trouble getting the seed project running on my mac and I thought it may help others. I've seen other projects offer two types of installation instructions (see the updates to README.md) and I thought that pattern would apply to this. People running the seed project can choose to run with the standard installation instructions or, if they find it easier, leverage Docker.

PatrickJS commented 7 years ago

I don't like having two package.jsons to manage