Closed mcescalante closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
All set, I signed the CLA! :)
CLAs look good, thanks!
I can confirm this works. Just deployed my package on a server after I merged these changes. Thanks!
@pascal08 if you are using this base and want Angular 4+ and other updated dependencies, I just added another commit that updates dependencies 😄
@mcescalante I just merged your changes and bumped my project to Angular 4. Works like a charm. This should be merged!
Changes:
angular2-in-memory-web-api
toangular-in-memory-web-api
to reflect latest package changes (package name changed, see https://www.npmjs.com/package/angular2-in-memory-web-api)html-webpack-plugin
and plugin towebpack.config.js
so thatnpm run build
outputs a working index.html file.I have tested bumped versions with a fresh clone. Happy to make additional changes if needed for this PR!