angular / angularfire

Angular + Firebase = ❤️
https://firebaseopensource.com/projects/angular/angularfire2
MIT License
7.64k stars 2.2k forks source link

BUG: Redundant function in Storage ref.ts file #2145

Closed rip222 closed 3 years ago

rip222 commented 4 years ago

Version info

Angular: 8.1.0

Firebase: 6.3.1

AngularFire: 5.2.1

Other (e.g. Ionic/Cordova, Node, browser, operating system): MacOSX HighSierra

Take a look at updateMetatdata function. Isn't it redundant?

export interface AngularFireStorageReference {
    getDownloadURL(): Observable<any>;
    getMetadata(): Observable<any>;
    delete(): Observable<any>;
    child(path: string): any;
    updateMetatdata(meta: SettableMetadata): Observable<any>;
    updateMetadata(meta: SettableMetadata): Observable<any>;
    put(data: any, metadata?: UploadMetadata | undefined): AngularFireUploadTask;
    putString(data: string, format?: string | undefined, metadata?: UploadMetadata | undefined): AngularFireUploadTask;
}
jamesdaniels commented 4 years ago

Hey there, it is indeed redundant as we had a spelling mistake. We've left it in this version though, because we don't want to break the API. We will remove it in the next major. Thanks for the PR.

jamesdaniels commented 3 years ago

Dropped in 6.